Comments on: Executing a SQL script using ADO.NET

By: Mihai

Mihai — Thu, 03 Apr 2008 00:05:45 +0000

Like all quick regex solutions intended to match productions of fairly complex languages, this can fail miserably if a different kind of GO is placed alone in one line. It could be part of a string (if T-SQL allows multiline strings, or it could be a column in a table).

I think having to make your commands single-line (which would incidentally fix the issue I mentioned) would be a terrible chore.

The bottom-line here is that you don’t want to write something that can come and bite you in the ass at an unknown time in the future. This tool is only guaranteed to work in synergy with a policy: “make sure all the GOs matchable by this regex in all the scripts are really those GOs…”. And you know, that’s a policy you don’t want.

Anyway, I’m sure the life of many is easier now, but at some point, somewhere, someone’s script is gonna blow and someone will have to go back to massage it. Hopefully not the client :)

By: Tim

Tim — Tue, 06 Nov 2007 20:22:12 +0000

The script above is already tied to a database, even without using SMO. Structures like SqlCommand and SqlTransaction are specific ado.net implementations for MS Sql Server. You could make an argument that using SMO would not allow this script to execute for a different flavor of MS Sql Server. If you want a true data agnostic implementation either us ADO.Net’s provider model (DbCommand, DbTransaction) or us the more generic Provider Model pattern.

By: Matt Berther

Matt Berther — Tue, 16 Oct 2007 14:29:16 +0000

@dave: I didnt have it open the connection because the connection was passed in. The assumption was the that method that calls this had already opened the connection.

By: Dave Coates

Dave Coates — Tue, 16 Oct 2007 07:48:59 +0000

U ROK!! Saved my life and LOTS of hours of searching…i changed it to so that it opens the connection tho, cause its not there…just in case u want to add that..

By: Mahammed Ali Shaik

Mahammed Ali Shaik — Mon, 24 Sep 2007 14:29:23 +0000

Just what I was looking for. Thanks!

Any one tell, how to generate scripts with data …

Thanks in adv..

@li

By: Justin

Justin — Fri, 31 Aug 2007 01:32:09 +0000

I am getting errors if my stored procedure has any comment marks in it “–” has anyone run into this is there a way around this so i can run a sql script just like i would in query analyzer to create stored procedure

By: Matt

Matt — Sun, 22 Jul 2007 05:06:01 +0000

I would suspect that you just wrap the calls in a try/catch. Something like that would probably come back as an exception.

By: Sooryanarayan

Sooryanarayan — Sun, 22 Jul 2007 05:02:15 +0000

HOw do you get back the response/messages the SQL generates while executing. FOr example : SQL Server generates the following message for dependancy SP

Cannot add rows to sysdepends for the current object because it depends on the missing object ‘uspTestDep’. The object will still be created.

I want to display on .NET screen.

Do you have any ideas?

By: Bees

Bees — Thu, 21 Jun 2007 17:14:45 +0000

works great, one thing, If you run a script that create and or drop tables you have to remove the Transaction section.

By: Jonathan Wentz

Jonathan Wentz — Mon, 11 Jun 2007 21:44:13 +0000

Here’s an updated regular expression that will handle white space around the GO keyword:
^\s*GO\s*$